Fixes bug where a new recurring run has no default trigger #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…racted with the trigger form
rileyjbauer
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rileyjbauer
changed the title
|
/lgtm |
IronPan
pushed a commit
that referenced
this pull request
Nov 8, 2018
* Fixes bug where a new recurring run has no trigger if user never interacted with the trigger form * Update snapshot tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NewRunonly updates its in-stateTriggerobject when its childTriggerelement callsonChange. This means if a user creates a new recurring run without ever interacting with theTriggerelement,onChangeis never called, and the resulting recurring run that is created has noTrigger.This PR fixes this bug, but a better solution is to have
NewRunpass theTriggerobject to theTriggerelement as a prop.This change is