Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Only install cloudpickle if it's not available #1434

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jun 4, 2019

This makes unit tests much faster.
Also:
Pined the version to 1.1.1.
Made the installation quiet.


This change is Reviewable

This makes unit tests much faster.
Also:
Pined the version to 1.1.1.
Made the installation quiet.
@gaoning777
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 4, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 4, 2019

/hold

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 4, 2019

/test kubeflow-pipeline-sample-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 5, 2019

/hold cancel

sample test is passing

@k8s-ci-robot k8s-ci-robot merged commit ab97d57 into kubeflow:master Jun 5, 2019
@Ark-kun Ark-kun deleted the SDK---Only-install-cloudpickle-if-it's-not-available branch June 5, 2019 20:13
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants