add tensorboard routing rule #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @yebrahim |
yebrahim
reviewed
Nov 8, 2018
test/presubmit-tests.sh
Outdated
| @@ -77,7 +77,7 @@ if [ "$CLUSTER_TYPE" == "create-gke" ]; then | |||
| echo "Delete cluster..." | |||
| gcloud container clusters delete ${TEST_CLUSTER} --async | |||
| } | |||
| trap delete_cluster EXIT | |||
| # trap delete_cluster EXIT | |||
There was a problem hiding this comment.
Remove or add [WIP] to the PR to remember to remove this.
| @@ -56,6 +57,46 @@ | |||
| }, | |||
| }, //serviceUi | |||
|
|
|||
| tensorboardUi: { | |||
There was a problem hiding this comment.
nit: rename to tensorboardData? The rest of the UI renders fine.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan, yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
IronPan
added a commit
that referenced
this pull request
Nov 8, 2018
* add tensorboard routing rule * rename tb routing rule * address comments * remove debugger * fix url prefix
IronPan
added a commit
that referenced
this pull request
Nov 8, 2018
* add tensorboard routing rule * rename tb routing rule * address comments * remove debugger * fix url prefix
k8s-ci-robot
pushed a commit
that referenced
this pull request
Nov 10, 2018
* add pipeline e2e test back * delete samples * more changes to pipeline test * add delete run/experiment * update test name * stage * add api * fii * add tensorboard routing rule (#143) * add tensorboard routing rule * rename tb routing rule * address comments * remove debugger * fix url prefix * more fixes * update tests * revert debugging * update * update test * fix * update test * fix * fix pipeline tests * exp * update run * update jobs
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
* We'd been using projects but not everyone can see projects.
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
…eflow#143) * Adds a mutating admission controller to inject GPU functionality into deployments * Updates * Added documentation * Pausing to sync github * Added tests for tolerations and nodeselectors * Added tensorflow support for GPUs * Passthrough annotation to configurations * Fix readme * Fixed runtime versions for tensorflow * fixed an annotation type * Added ignored framework files * Removed unnecessary dependency * Fixed a typo in README * Refactored tests * added a space * Made mutate a private method * Cleaned up paths
HumairAK
pushed a commit
to red-hat-data-services/data-science-pipelines
that referenced
this pull request
Mar 11, 2024
* PipelineRun with embedded pipelineSpec and taskSpec Closes kubeflow#143 * Preserve empty string default values * Remove success_condition and failure_condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is