Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update DSL client documentation #1403

Merged
merged 2 commits into from
May 31, 2019
Merged

update DSL client documentation #1403

merged 2 commits into from
May 31, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented May 30, 2019

/assign @hongye-sun


This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented May 30, 2019

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented May 31, 2019

/test kubeflow-pipeline-e2e-test

@IronPan
Copy link
Member Author

IronPan commented May 31, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7447eb3 into master May 31, 2019
@IronPan IronPan deleted the IronPan-patch-1 branch June 4, 2019 07:24
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
kubeflow#1403)

* patch inferenceservice annotations to kfserving routing virtualservice

* add filters

* remove label filtering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants