Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the link to the SDK reference docs to README.md #1398

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented May 29, 2019

This change is Reviewable

@IronPan
Copy link
Member

IronPan commented May 29, 2019

/lgtm
/assign @sarahmaddox

@IronPan
Copy link
Member

IronPan commented May 29, 2019

/approve
/hold
i'll let you decide if you want sarah to take a look or not

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 29, 2019

Thanks.

I think given the priority it's fine to just add the links.\

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit f879f54 into master May 29, 2019
@Ark-kun Ark-kun deleted the avolkov/Added-the-link-to-the-SDK-reference-docs-to-README.md branch May 29, 2019 22:54
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Magic DNS setup instruction

* Curl with internal host
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Fix bytes string literal check in preprocess

Add json to kfserving requirements

Fix test

Instruction for calling inference service with magic DNS (kubeflow#1398)

* Magic DNS setup instruction

* Curl with internal host

PR comments

More tests for UnicodeDecodeError exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants