Cleanup code - Kaniko pod parameterization #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fix #1316 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This is not fixing the parameterized issue, though. |
|
The "default" ns should be ok. And the top level user facing function should optionally accept the namespace, since user not always have permission to default namespace in multi-tenant case. |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
…ubeflow#1394) * Set ModelSpec memory to required * Added validation webhook * Added validation webhook test * Added validation webhook for trained models * Registered trained model webhook * Updated kubebuilder webhook marker name * Added comments and function validateMemoryNotModified for clarity * refactored variables and constants for clarity on memory spec * Changed variable for consistency: currentTmMemory -> oldTmMemory * Changed apiVersions to v1alpha1 * Added newline * Displayed quantity value as a string * Added trained model validation webhook * Update logger and error message * Changed test to follow Table-Drive-Development
HumairAK
added a commit
to red-hat-data-services/data-science-pipelines
that referenced
this pull request
Mar 11, 2024
…beflow#1394. (kubeflow#1395) Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
HumairAK
added a commit
to red-hat-data-services/data-science-pipelines
that referenced
this pull request
Mar 11, 2024
…beflow#1394. (kubeflow#1395) Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
HumairAK
added a commit
to red-hat-data-services/data-science-pipelines
that referenced
this pull request
Mar 11, 2024
…beflow#1394. (kubeflow#1395) Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @gaoning777 @Ark-kun
This change is