Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tutorials/Lightweight Python components #139

Merged
merged 3 commits into from
Nov 7, 2018
Merged

Tutorials/Lightweight Python components #139

merged 3 commits into from
Nov 7, 2018

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 7, 2018 •
edited
Loading

Implements #69

This change is Reviewable

gaoning777
gaoning777 reviewed Nov 7, 2018
View reviewed changes
Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the sample. However, I do not think it is a good idea to expose the component sharing scenario before we have a better story of that.

gaoning777
gaoning777 approved these changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaoning777
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 7, 2018

Talked offline with @gaoning777 and @paveldournov.
For now, I've removed the notebooks that show how to save the component to a file to load it later in a different notebook. Adding them would require too much documentation.

@k8s-ci-robot k8s-ci-robot merged commit c9412e1 into master Nov 7, 2018
@Ark-kun Ark-kun deleted the avolkov/Tutorials---Lightweight-Python-components branch November 9, 2018 23:36
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@k8s-ci-robot
Add PVC for dev.kubeflow.org (kubeflow#139)
6d3e487
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@animeshsingh
update features (kubeflow#139)
23ff2a6 
* update features

* fix hyperlink
HumairAK added a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@HumairAK
Merge pull request kubeflow#139 from HumairAK/add_to_proj_action
36f85f2 
Add gh workflow to auto add issues to proj.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 gaoning777 approved these changes

@paveldournov paveldournov Awaiting requested review from paveldournov

@qimingj qimingj Awaiting requested review from qimingj

@vicaire vicaire Awaiting requested review from vicaire

Assignees

@gaoning777 gaoning777

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ark-kun @gaoning777 @k8s-ci-robot