Fixed the handling of PipelineParam-based default values in extract_metadata #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test kubeflow-pipeline-e2e-test |
1 similar comment
|
/test kubeflow-pipeline-e2e-test |
gaoning777
reviewed
May 24, 2019
|
/test kubeflow-pipeline-e2e-test |
1 similar comment
|
/test kubeflow-pipeline-e2e-test |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* update MMS readme * format * Update docs/MULTIMODELSERVING_GUIDE.md Co-authored-by: Dan Sun <dsun20@bloomberg.net> * Update docs/MULTIMODELSERVING_GUIDE.md Co-authored-by: Dan Sun <dsun20@bloomberg.net> * Update docs/MULTIMODELSERVING_GUIDE.md Co-authored-by: Dan Sun <dsun20@bloomberg.net> * Update docs/MULTIMODELSERVING_GUIDE.md Co-authored-by: Dan Sun <dsun20@bloomberg.net> * Update docs/MULTIMODELSERVING_GUIDE.md Co-authored-by: Dan Sun <dsun20@bloomberg.net> * Update docs/MULTIMODELSERVING_GUIDE.md Co-authored-by: Dan Sun <dsun20@bloomberg.net> * Update docs/MULTIMODELSERVING_GUIDE.md Co-authored-by: Dan Sun <dsun20@bloomberg.net> * update readme * remove duplicate Co-authored-by: Dan Sun <dsun20@bloomberg.net>
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
…eflow#1385) * fix aix mnist example * adapt the aixserver to accept inputs on the explainer's parameters * Update main README to use v1beta1 sklearn as example (kubeflow#1384) * Use latest image for default overlay * Rename to irisv2 * Fix release gen script * Move local gateway section * Update quick install * Add kubeflow release assets * Update quick install for 0.5 * Remove crd config * Move sklearn examples * Fix local gateway * fix sklearn iris v2 example * Update docs/samples/v1beta1/sklearn/v1/README.md Co-authored-by: yuzliu <55463421+yuzliu@users.noreply.github.com> Co-authored-by: yuzliu <55463421+yuzliu@users.noreply.github.com> * the original parameters change will not modify parameters from the request * Update MMS readme (kubeflow#1380) * update MMS readme * format * Update docs/MULTIMODELSERVING_GUIDE.md Co-authored-by: Dan Sun <dsun20@bloomberg.net> * Update docs/MULTIMODELSERVING_GUIDE.md Co-authored-by: Dan Sun <dsun20@bloomberg.net> * Update docs/MULTIMODELSERVING_GUIDE.md Co-authored-by: Dan Sun <dsun20@bloomberg.net> * Update docs/MULTIMODELSERVING_GUIDE.md Co-authored-by: Dan Sun <dsun20@bloomberg.net> * Update docs/MULTIMODELSERVING_GUIDE.md Co-authored-by: Dan Sun <dsun20@bloomberg.net> * Update docs/MULTIMODELSERVING_GUIDE.md Co-authored-by: Dan Sun <dsun20@bloomberg.net> * Update docs/MULTIMODELSERVING_GUIDE.md Co-authored-by: Dan Sun <dsun20@bloomberg.net> * update readme * remove duplicate Co-authored-by: Dan Sun <dsun20@bloomberg.net> * Feature to include headers in http/https service requests (non-MMS) (kubeflow#1372) * Added http(s) header support extracted from env var + tar format * Created http(s) uri secret support to extract headers * Created tests for http(s) secret extraction * Added condition to extract secret volume from uri * Added how to set headers for http(s) uri request in secret * Added minor note on formatting * Added minor note on how to convert to base64 * refactored variable name and introduced constant * Secret Data Key Header -> Headers * Changed base-uri -> host-uri for consistency * Checked secret data for https-host-uri instead of annotation * Moved host uri to secret data * Added parsing logic for headers/host uri in secret data * Fixed test to match host uri in secret data * Updated variables for clarity * Stored header as a json string in env * Parse header as json * Update headers to store json * Removed unnecessary code * Update docs/samples/explanation/aix/mnist/README.md * fix aix mnist example * adapt the aixserver to accept inputs on the explainer's parameters * the original parameters change will not modify parameters from the request * Update docs/samples/explanation/aix/mnist/README.md Co-authored-by: Dan Sun <dsun20@bloomberg.net> Co-authored-by: yuzliu <55463421+yuzliu@users.noreply.github.com> Co-authored-by: abchoo <77467773+abchoo@users.noreply.github.com> Co-authored-by: Animesh Singh <singhan@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Pipeline metadata extraction fails with error when the pipeline uses
PipelineParamin the signature:This happens because the code in
_extract_*_metadataconsiders the wholePipelineParamobject as default value instead of getting the default value from its.valueproperty.This PR fixes this error.
This change is