Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add todos for the image tag update for new releases #138

Merged
merged 2 commits into from
Nov 9, 2018

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Nov 7, 2018

This change is Reviewable

Copy link
Contributor

@qimingj qimingj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like a never ending TODO. :)

@qimingj
Copy link
Contributor

qimingj commented Nov 8, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777
Copy link
Contributor Author

It is an everlasting TODO until we either have an automatic releasing with image tag update.

@qimingj
Copy link
Contributor

qimingj commented Nov 9, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit e639a36 into master Nov 9, 2018
@gaoning777 gaoning777 deleted the ngao/add-todo-for-release branch November 9, 2018 02:17
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Executor with preprocess, predictor and postprocess

* update variable names

* lint update

* Updates from review comments

* Remove proxy implementation and add initial simple client calls to pre/post and predict

* Add check predictor argument supplied

* Updates from review
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* add wml sample

* address comments

* adjust sentence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants