Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HyperParameters back to SageMaker training job #1377

Merged
merged 1 commit into from
May 31, 2019
Merged

Add HyperParameters back to SageMaker training job #1377

merged 1 commit into from
May 31, 2019

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented May 23, 2019 •
edited by jlewi
Loading

To address #1370

This change is Reviewable

@Jeffwan
Copy link
Member Author

Jeffwan commented May 24, 2019

/test kubeflow-pipeline-e2e-test

2 similar comments
@Ark-kun
Copy link
Contributor

Ark-kun commented May 24, 2019

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor

Ark-kun commented May 28, 2019

/test kubeflow-pipeline-e2e-test

animeshsingh
animeshsingh approved these changes May 29, 2019
View reviewed changes
Copy link
Contributor

@animeshsingh animeshsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Jeffwan
Copy link
Member Author

Jeffwan commented May 29, 2019

@Ark-kun Looks like it pass test. Please have another look.

@Ark-kun
Copy link
Contributor

Ark-kun commented May 31, 2019

/approve

In future you should probably either parametrize or deprecate those parameters.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d5147b9 into kubeflow:master May 31, 2019
@Jeffwan
Copy link
Member Author

Jeffwan commented May 31, 2019 •
edited
Loading

Agree. There's lots of first party algorithms and their hyper parameter is different, agree that I need to customize this part in next change to make it generate and avoid code change.

@Jeffwan Jeffwan deleted the add_hyper_parameter branch May 31, 2019 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@animeshsingh animeshsingh animeshsingh approved these changes

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees

@animeshsingh animeshsingh

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jeffwan @Ark-kun @k8s-ci-robot @animeshsingh