Add a sample notebook. #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paveldournov
suggested changes
Nov 7, 2018
| "outputs": [], | ||
| "source": [ | ||
| "# test the function and make sure it works.\n", | ||
| "path = 'gs://bradley-playground/pipeline-tfjob-k6s6z/train/'\n", |
There was a problem hiding this comment.
Can we templatize it and have a variable with the project name people can change?
| "compiler.Compiler().compile(my_taxi_cab_classification, 'my-tfx.tar.gz')\n", | ||
| "\n", | ||
| "run = client.run_pipeline(exp.id, 'my-tfx', 'my-tfx.tar.gz',\n", | ||
| " params={'output': 'gs://bradley-playground',\n", |
There was a problem hiding this comment.
Same here, please use a variable with a project name.
There was a problem hiding this comment.
Done. Thanks for the feedback.
|
PTAL? |
paveldournov
approved these changes
Nov 7, 2018
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paveldournov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
This is great that we have a notebook sample. |
HumairAK
added a commit
to red-hat-data-services/data-science-pipelines
that referenced
this pull request
Mar 11, 2024
…54f2551f9fd37696c74c53eb [Snyk] Security upgrade node from 14.18.2-alpine to 14.21.3-alpine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is