Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Added the argo-models to requirements.txt #1367

Merged

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented May 22, 2019

requirements.txt needs to be consistent with setup.py.


This change is Reviewable

@gaoning777
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 22, 2019

/approve

@michelle192837
Copy link

/hold

@michelle192837
Copy link

Tide is failing to merge this; see #1371

@Ark-kun Ark-kun force-pushed the SDK---Added-Argo-to-requirements.txt branch from c5afada to bdb43d3 Compare May 22, 2019 20:06
@k8s-ci-robot k8s-ci-robot removed the lgtm label May 22, 2019
@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 22, 2019

/hold cancel
/approve
@gaoning777 Can you please re-lgtm? (I've just re-pushed the same change to restart Travis. There were no changes)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit f4436c2 into kubeflow:master May 22, 2019
@Ark-kun Ark-kun deleted the SDK---Added-Argo-to-requirements.txt branch May 22, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants