Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require full function signatures #136

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Conversation

yebrahim
Copy link
Contributor

@yebrahim yebrahim commented Nov 7, 2018

No functional changes, added stricter boolean return type enforcement and missing awaits (that don't change any behavior as of now).


This change is Reviewable

@yebrahim yebrahim changed the title [WIP] Require function signatures Require function signatures Nov 8, 2018
@yebrahim
Copy link
Contributor Author

yebrahim commented Nov 8, 2018

ping

Copy link
Contributor

@rileyjbauer rileyjbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved and removed lgtm labels Nov 8, 2018
@rileyjbauer
Copy link
Contributor

/lgtm

@rileyjbauer
Copy link
Contributor

/lgtm

@yebrahim yebrahim changed the title Require function signatures Require full function signatures Nov 8, 2018
@k8s-ci-robot k8s-ci-robot merged commit 3aa7643 into master Nov 8, 2018
@yebrahim yebrahim deleted the yebrahim/tslint-signature branch November 9, 2018 07:59
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* fix golint install message

* Fix copy paste error in verify-golint
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
HumairAK added a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
…7e9668cdfb50b272e7e68285

[Snyk] Security upgrade alpine from 3.11 to 3.16.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants