404 page

[yebrahim]

Fixes #55.

---

This change is 

[yebrahim]

Ping.

[qimingj]

@rileyjbauer can you review it?

[Ark-kun]

Is this a real 404? (Does it give the 404 HTTP code?)

Can you just add <Route path="*" component={NoMatch} status={404}/> ?

Also see https://stackoverflow.com/a/40805821/1497385

[yebrahim]

Pipelines UI is singe page app, which means all the routing is done on the client, so the server sends the HTML/JS/CSS bundle just once (or multiple times when we have code splitting), returning 200 status, and never serving such requests again.

But what's the value of having a 404 return code here? We don't really care about search engine crawling, SEO, or any of that, we're not a public website either

[Ark-kun]

When I visit a non-existing url like http://localhost:8080/pipelines/ I'd like to see a proper error instead of a blank page with some scripts.

[yebrahim]

That requires a change to Ambassador, it's not something the Pipelines frontend can handle. A request to /pipelines won't even reach our webserver.

[Ark-kun]

That requires a change to Ambassador, it's not something the Pipelines frontend can handle. A request to /pipelines won't even reach our webserver.

Understood. Then how does this fix #55 ?

[yebrahim]

I misread your issue. This fixes all frontend-managed pages. For example if the Pipelines UI is at http://localhost:8080/pipeline then this handles going to http://localhost/pipeline/#/jobz instead of http://localhost/pipeline/#/jobs.

Outside this change, that issue shouldn't be on the Pipelines repo, it should be on kubeflow/kubeflow, that's where the Ambassador config is managed.

[rileyjbauer]

/lgtm
/approve

[rileyjbauer]

/retest

[yebrahim]

/test build-image

[coveralls]

Pull Request Test Coverage Report for Build 278

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 13 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.02%) to 67.531%

---

Files with Coverage Reduction	New Missed Lines	%
src/components/Router.tsx	13	49.18%

Totals
Change from base Build 265:	0.02%
Covered Lines:	1542
Relevant Lines:	2193

---

💛 - Coveralls

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [rileyjbauer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [rileyjbauer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rileyjbauer]

/lgtm