Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim the file extension from suggested pipeline names #1349

Merged
merged 1 commit into from
May 17, 2019

Conversation

rileyjbauer
Copy link
Contributor

@rileyjbauer rileyjbauer commented May 16, 2019

Fixes #1340


This change is Reviewable

@rileyjbauer rileyjbauer changed the title Trims the file extension from suggested pipeline names Trim the file extension from suggested pipeline names May 16, 2019
@rileyjbauer
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@neuromage
Copy link
Contributor

/lgtm

@rileyjbauer
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit be4febc into kubeflow:master May 17, 2019
@rileyjbauer rileyjbauer deleted the trim-file-ext branch May 21, 2019 23:55
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Fix cvxpy to 1.1.7

* Fix numpy dep as 1.20.0 breaks lgbserver

* Turn back lightgbm test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: don't include the '.py.tar.gz' suffix when generating a pipeline name from an upload
3 participants