Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK/Compiler: Fix Ops after() method to handle multiple arguments #1346

Merged
merged 1 commit into from
May 16, 2019

Conversation

elikatsis
Copy link
Member

@elikatsis elikatsis commented May 16, 2019

Instead of doing

op = dsl.ContainerOp(...).after(step1).after(step2)....

make the following possible

op = dsl.ContainerOp(...).after(step1, step2, ...)

This change is Reviewable

Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
@k8s-ci-robot k8s-ci-robot requested review from Ark-kun, gaoning777 and hongye-sun and removed request for Ark-kun May 16, 2019 20:49
@elikatsis
Copy link
Member Author

/ok-to-test

@Ark-kun
Copy link
Contributor

Ark-kun commented May 16, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 78bfdaf into kubeflow:master May 16, 2019
@elikatsis elikatsis mentioned this pull request May 30, 2019
@elikatsis elikatsis deleted the baseop-after branch March 9, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants