Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename sample_test to component_test and sample_test_v2 to sample_test #1341

Merged
merged 1 commit into from
May 16, 2019
Merged

rename sample_test to component_test and sample_test_v2 to sample_test #1341

merged 1 commit into from
May 16, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented May 15, 2019

This change is Reviewable

@gaoning777
Copy link
Contributor Author

The yaml filename in test-infra is updated in: kubernetes/test-infra#12663

@Ark-kun
Copy link
Contributor

Ark-kun commented May 15, 2019

/lgtm

@gaoning777
Copy link
Contributor Author

Will approve after the test-infra PR gets merged.

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit 6554e13 into kubeflow:master May 16, 2019
@gaoning777 gaoning777 deleted the update-test-filename branch May 16, 2019 20:28
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants