Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky basic sample test #134

Merged
merged 8 commits into from
Nov 7, 2018
Merged

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Nov 7, 2018

This change is Reviewable

test/presubmit-tests.sh Outdated Show resolved Hide resolved
@gaoning777 gaoning777 changed the title [WIP] fix flaky basic sample test Fix flaky basic sample test Nov 7, 2018
test/presubmit-tests.sh Outdated Show resolved Hide resolved
@vicaire
Copy link
Contributor

vicaire commented Nov 7, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 7, 2018
@vicaire
Copy link
Contributor

vicaire commented Nov 7, 2018

/lgtm

test/presubmit-tests.sh Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 7, 2018
@vicaire
Copy link
Contributor

vicaire commented Nov 7, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a540cf7 into master Nov 7, 2018
@gaoning777 gaoning777 deleted the ngao/basic-sample-test-flaky branch November 7, 2018 22:50
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* add initial support for tensorrt

* rename modelrepo to modeluri

* make tensorrt container configurable

* update readme since tensorRT is not a format

* pint out that tensorRT is a server not a model type

* tensorrt sample

* dont set things that are default

* fix port arg

* fix args per reccomendation

* add simple test

* remove port name

* add instructions to check status

* add a note for the nvcr.io issue

* fix test failures

* add oxford comma and call out inference servers

* remove tensorrt from core CUJs

* rename service to framework-dataset

* point to official bucket

* remove entrypoint since its args

* add ref to download issue

* add reference to nvidia versioning scheme

* use jsonpath for servicename

* fix readme

* minor edits to readme

* make shorter sentences

* fix modelUri

* remove echo

* Case Constants

* add tensorrt image to config

* add missing comma in kfservice config

* point yaml to correct place and fix readme

* add trt runtime version validation
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* add trusted ai example

* add hyperlink

* update feature flag for example
HumairAK added a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
…329d4875621306ded589cb74

[Snyk] Security upgrade fluent/fluentd from v1.11-1 to v1.16.2-1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants