Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy agent as optional kustomize component #1325

Merged
merged 5 commits into from
May 14, 2019
Merged

Add proxy agent as optional kustomize component #1325

merged 5 commits into from
May 14, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented May 14, 2019

Proxy agent is added as an optional component for user to access KFP.
For more details how to use proxy agent, see the updated readme.


This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented May 14, 2019

/assign @Ark-kun @vicaire @paveldournov

@Ark-kun
Copy link
Contributor

Ark-kun commented May 14, 2019

It looks like you're doing more than just adding the proxy kustomize component here. Some stray changes?

@ojarjur
Copy link

ojarjur commented May 14, 2019

The proxy-agent bits look good to me, but I will echo Alexey's comment about the seemingly unrelated file deletions that should be a different PR

@IronPan
Copy link
Member Author

IronPan commented May 14, 2019

done. sorry it was based on a wrong branch.

@Ark-kun
Copy link
Contributor

Ark-kun commented May 14, 2019

/lgtm

@IronPan
Copy link
Member Author

IronPan commented May 14, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 47efd82 into master May 14, 2019
@IronPan IronPan deleted the rp branch May 30, 2019 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants