-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxy agent as optional kustomize component #1325
Conversation
/assign @Ark-kun @vicaire @paveldournov |
It looks like you're doing more than just adding the proxy kustomize component here. Some stray changes? |
The proxy-agent bits look good to me, but I will echo Alexey's comment about the seemingly unrelated file deletions that should be a different PR |
done. sorry it was based on a wrong branch. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proxy agent is added as an optional component for user to access KFP.
For more details how to use proxy agent, see the updated readme.
This change is