Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dsl support for preemptible vm/gpus #1306

Merged
merged 2 commits into from
May 14, 2019
Merged

Add dsl support for preemptible vm/gpus #1306

merged 2 commits into from
May 14, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented May 10, 2019

This change is Reviewable

@gaoning777 gaoning777 changed the title add dsl support for preemptible vm/gpus [WIP] add dsl support for preemptible vm/gpus May 10, 2019
sdk/python/kfp/gcp.py Outdated Show resolved Hide resolved
@gaoning777 gaoning777 changed the title [WIP] add dsl support for preemptible vm/gpus Add dsl support for preemptible vm/gpus May 11, 2019
@gaoning777
Copy link
Contributor Author

@Ark-kun @hongye-sun Any concerns about this PR? Thanks

@Ark-kun
Copy link
Contributor

Ark-kun commented May 13, 2019

/lgtm

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

1 similar comment
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit 6fcab51 into kubeflow:master May 14, 2019
@gaoning777 gaoning777 deleted the add-preemptible-apply-function branch May 14, 2019 16:05
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
…e test with sklearn/xgboost examples + docs (kubeflow#1306)

* Imported trained model spec and model spec

* Update description: trained model -> TrainedModel

* Considers model name in predict query

* Multi model serving test for sklearn and xgboost

* Constants for v1alpha versions

* Provider client is generated when downloading

* New method to create/deploy trained model object

* Example on running multi model serving

* Snake case variable -> Camel case

* Using new version constants

* CreateProviderIfNotExists will return provider and error

* Updated to use GetProvider

* Corrected the file path

* Removed object file path when creating fileName

* Added overview of multi-model serving

* Overview of inferenceservice, trainedmodel, and model agent

* Removed check for version in create_trained_model

* Multi-model serving example for sklearn

* Moved provider creation to package agent storage

* Fixed up confusing wording

* Fixed up typo

* Included detailed diagram

* Added general overview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants