-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend - Marking auto-added artifacts as optional #1289
Backend - Marking auto-added artifacts as optional #1289
Conversation
The tests are currently failing since they use the wrong Argo version (despite updated |
You can run
|
Thanks.
|
TF has fixed the issue ~1 month ago tensorflow/tensorflow@494d2cc It's part of the v1.12.2 release, but not v1.13.1. |
All the tests are passing. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@IronPan Looks like there is a problem in how Kubeflow deploys Argo. They deploy two workflow controllers with different configurations (one in |
This PR is implementing part of the #1250 plan.
Problem:
DSL-compiler has been auto-adding two artifacts to all pipeline tasks (including ones that do not actually outputs those artifacts). All out existing compiled pipelines have this problem.
Argo 2.3 makes missing output artifacts a reason for task failure.
The workaround for the existing pipelines is for backend to mark those two artifacts as optional.
P.S.
The
optional
property is only available starting with Argo 2.3, so I'm bumping the Argo version.This change is