Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update component yaml reference to eb830cd73ca148e5a1a6485a9374c2dc068314bc #1282

Merged
merged 1 commit into from
May 3, 2019
Merged

Update component yaml reference to eb830cd73ca148e5a1a6485a9374c2dc068314bc #1282

merged 1 commit into from
May 3, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented May 3, 2019 •
edited by jlewi
Loading

This change is Reviewable

@hongye-sun
Copy link
Contributor Author

/hold

Wait for sample test to finish.

@Ark-kun
Copy link
Contributor

Ark-kun commented May 3, 2019

/lgtm

@hongye-sun
Copy link
Contributor Author

/hold cancel
/approve

All tests passed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented May 3, 2019

BTW, This whole process is getting automated in #1283

@hongye-sun hongye-sun merged commit f56a8cb into kubeflow:master May 3, 2019
hamedhsn pushed a commit to hamedhsn/pipelines that referenced this pull request May 5, 2019
@hongye-sun @hamedhsn
Comp yaml eb830cd (kubeflow#1282)
82bf1df
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@kd303 @animeshsingh
Update KFSERVING_DEBUG_GUIDE.md (kubeflow#1282)
95a5d2a 
* Update KFSERVING_DEBUG_GUIDE.md

Added the description for failing probes and 404 as per suggestion by @yuzisun on issue [1153]#(kserve/kserve#1153)

* Apply suggestions from code review

Co-authored-by: Animesh Singh <singhan@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@animeshsingh animeshsingh Awaiting requested review from animeshsingh

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

Assignees

@Ark-kun Ark-kun

@IronPan IronPan

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hongye-sun @Ark-kun @k8s-ci-robot @IronPan