Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - Simplified python package building #1277

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented May 3, 2019

This change is Reviewable

@hongye-sun
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 3, 2019

/approve

1 similar comment
@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 3, 2019

/approve

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 3, 2019

/assign @IronPan

@IronPan
Copy link
Member

IronPan commented May 8, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0cd052b into kubeflow:master May 9, 2019
@Ark-kun Ark-kun deleted the Release---Simplified-python-package-building branch May 9, 2019 22:18
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
… protocol (kubeflow#1277)

* Use ModelClassName to differiate kfserver and torchserve implementation for v1 protocol

* Update torchserve examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants