display kaniko log if failed #1247
Conversation
|
The resulting log looks as follows: |
| return | ||
| setattr(_configure_logger, 'configured', 'true') |
There was a problem hiding this comment.
You can probably just write.
| setattr(_configure_logger, 'configured', 'true') | |
| _configure_logger.configured = 'true' |
There was a problem hiding this comment.
I tried to keep the code consistent using hasattr and setattr.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipeline-e2e-test |
2 similar comments
|
/test kubeflow-pipeline-e2e-test |
|
/test kubeflow-pipeline-e2e-test |
This change is