updated ffdl notebook using component yaml file #1241
Conversation
| }, | ||
| { | ||
| "attachments": { | ||
| "Screen%20Shot%202019-02-15%20at%204.50.17%20PM.png": { |
There was a problem hiding this comment.
Can you please include the images by reference?
There was a problem hiding this comment.
Would love to have the notebook as a unit which somebody can just take, without reference to anything out of the notebook
There was a problem hiding this comment.
There was a problem hiding this comment.
Hmm. GitHub does not seem to show the images:
Also TF seems to be using HTML IMG even for small images https://github.com/tensorflow/docs/blob/b5cb76b01b96fb936edb29ac0323a2d630d575ac/site/en/r2/tutorials/eager/tf_function.ipynb
There was a problem hiding this comment.
I would vote for a link in the ipynb file and publishing the image in the same directory or on the internet.
- I've searched throughout the web about embedding images in ipynb, people always attach a link to the image in the ipynb.
- Sharing a notebook vs. a directory does seem to be much different. Plus, the image can always be published in a publicly available cloud storage if the author wants to.
- It does not seem to be rendered correctly on the github.
There was a problem hiding this comment.
Ok removed the image reference for now. Will revisit later
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change is