Fixing comp names #1239
Fixing comp names #1239
Conversation
Kubernetes' labels are strict and probably should not be used for this. Use annotations instead. |
|
This is something we discussed - values in labels are just metadata we need to display on our custom UI, not passed to Kube. Also the same pipeline works fine if I go through python code directly - running from notebook is when that error message pops up. For now this gives a safer option |
The thing is that they are actually passed. |
|
Thanks. Can we merge this @Ark-kun. As mentioned, for now our internal systems are coded to use metadata.labels, and many internal components we have created are using this. Once we are able to test/verify and convert everything to annotations, we can come back and change this. |
Ok. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Moving the verb in comp names before because of UI real estate, plus removing the space in metadata label value as Jupyter notebook driven pipelines are complaining about the space
metadata.labels: Invalid value: "Open Source": a valid label must be an empty string or consist of alphanumeric characters, '-', '' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9.]*)?[A-Za-z0-9])?')
This change is