Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Removing unneeded uses of dsl.Pipeline #1229

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Apr 25, 2019

dsl.Pipeline is a private compiler context object that should not be used outside the compiler (and compiler tests).
This PR removes most of the unnecessary uses of dsl.Pipeline.
Please turn on "Hide whitespace changes" in diff settings when looking at the diff.


This change is Reviewable

@Ark-kun Ark-kun requested a review from gaoning777 April 25, 2019 07:10
@Ark-kun Ark-kun changed the title SDK - Removing unneeded usages of dsl.Pipeline SDK - Removing unneeded uses of dsl.Pipeline Apr 25, 2019
@Ark-kun Ark-kun force-pushed the SDK---Removing-unneeded-usages-of-dsl.Pipeline branch from 2f56c0a to 1932b7f Compare April 25, 2019 07:56
@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 14, 2019

Ping
/cc @gaoning777

@gaoning777
Copy link
Contributor

Sorry for the delay. I'll take a look today.

@gaoning777
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 14, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a41bd10 into kubeflow:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants