-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK - Separated the generated api client package #1214
SDK - Separated the generated api client package #1214
Conversation
/test kubeflow-pipeline-e2e-test |
/test kubeflow-pipeline-sample-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fairly fundamental set of changes. Do you have any tests to prove that they don't break any functionality? Also, where are the changes to the swagger client generation?
dd23973
to
f1f937f
Compare
Here they are: https://github.com/kubeflow/pipelines/blob/dfca0f208ee5cdfa27ae97e44b1c653a4ef65988/sdk/python/build_kfp_server_api_package.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start
4abe0a5
to
d9fa012
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm pending == -> >= in the setup.py script
/lgtm; package version update note needs to go into the release playbook |
/lgtm |
Sure. I'll add it. |
/approve |
@@ -0,0 +1,73 @@ | |||
#!/bin/bash -e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be put in sdk/ folder? backend/api is intend to be language agnostic. all language specific clients are currently located in the client folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's where I put it initially...
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun, IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How often is the api sdk released? is it going to be the same as the pipeline release? |
Separating the generated API client brings many benefits.
python setup.py sdist
to build orpython setup.py install
to install the packageClient
code: Instead of having 5 separate but identical configuration classes and 5 separate but identical API client classes it now only has 1.This change is