Testing/Sample - Made checking confusion matrix data more robust #1196
Conversation
The sample tests no longer depend on particular file names inside the archive. Now they only depend on the artifact name.
|
Could you debug the sample test error, please? |
Ark-kun
changed the title
Thanks for noticing this. Looks like I'll fix that. |
`json.load` only supports reading from binary files in python 3.6+. https://docs.python.org/3/library/json.html#json.load
|
/test kubeflow-pipeline-e2e-test |
Sample test succeeds now. |
Ark-kun
changed the title
|
The link(https://docs.python.org/3/library/json.html#json.load) says it supports both text and binary. |
|
/lgtm |
That's what I was thinking. Unfortunately, the footnote at that link is:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ark-kun
deleted the
Testing/Sample---Made-getting-artifact-data-more-robust
branch
* Add V2 support to XGBoost predictor * Add V2 server for XGBoost to configmap * Add test for XGBoost v2 * Add docs for XGBoost V2 predictor * Fix typo in config * Fix references in SKLearn readme * Fix XGBoost tests * Fix tests
The sample tests no longer depend on particular file names inside the archive. Now they only depend on the artifact name.
This change is