Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Python Client robust to existing IPython installations #1186

Merged
merged 2 commits into from
Apr 19, 2019
Merged

Make Python Client robust to existing IPython installations #1186

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8ab330
Make Client robust to IPython installations
JohnPaton Apr 18, 2019
db2d876
Return false directly instead of raising
Ark-kun Apr 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Make Client robust to IPython installations
  • Loading branch information
@JohnPaton
JohnPaton committed Apr 18, 2019
commit c8ab330c575cd4155e487dc337a3234e98e88155
3 changes: 3 additions & 0 deletions sdk/python/kfp/_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ def _is_ipython(self):
"""Returns whether we are running in notebook."""
try:
import IPython
ipy = IPython.get_ipython()
if ipy is None:
raise ImportError("IPython installed but not running")
JohnPaton marked this conversation as resolved.
Show resolved Hide resolved
except ImportError:
return False

Expand Down