Skip to content

Conversation

dolfim-ibm
Copy link
Contributor

Description of your changes:

This PR widen the allowed versions of urllib3 to improve the compatibility with the broader ecosystem.

Checklist:

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Copy link

Hi @dolfim-ibm. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

🚫 This command cannot be processed. Only organization members or owners can use the commands.

@hbelmiro
Copy link
Contributor

/ok-to-test

@zazulam
Copy link
Collaborator

zazulam commented Apr 11, 2025

/retest

@zazulam
Copy link
Collaborator

zazulam commented Apr 11, 2025

/lgtm

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@HumairAK
Copy link
Collaborator

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 866ff35 into kubeflow:master Apr 14, 2025
35 checks passed
@rafcis02
Copy link

@dolfim-ibm @HumairAK It seems it introduced a bug in GCP components #11880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants