Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marked all scripts as executable #1177

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Marked all scripts as executable #1177

merged 1 commit into from
Apr 23, 2019

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Apr 16, 2019 •
edited by jlewi
Loading

This change is Reviewable

animeshsingh
animeshsingh approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@animeshsingh animeshsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 17, 2019

/approve

1 similar comment
@rileyjbauer
Copy link
Contributor

/approve

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 18, 2019

/cc @IronPan

IronPan
IronPan reviewed Apr 19, 2019
View reviewed changes
Copy link
Member

@IronPan IronPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it necessary to change mode of the test script?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 19, 2019 •
edited
Loading

is it necessary to change mode of the test script?

I want to run some of them directly (not just include the code).
Sure, right now we use source to "run" the scripts, but that's pretty hacky.

@IronPan
Copy link
Member

IronPan commented Apr 23, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh, Ark-kun, IronPan, rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh, Ark-kun, IronPan, rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 173ecbd into kubeflow:master Apr 23, 2019
@Ark-kun Ark-kun deleted the Marked-scripts-as-executable branch April 25, 2019 06:36
@gaoning777
Copy link
Contributor

JFYI, source a script is different from directly running the script.
Source will run the script in the same bash where all the environment variables are retained.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 29, 2019

Thanks for the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan IronPan left review comments

@animeshsingh animeshsingh animeshsingh approved these changes

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@vicaire vicaire Awaiting requested review from vicaire

@rileyjbauer rileyjbauer Awaiting requested review from rileyjbauer

Assignees

@IronPan IronPan

@animeshsingh animeshsingh

@gaoning777 gaoning777

@rileyjbauer rileyjbauer

Labels
approved area/testing lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Ark-kun @rileyjbauer @IronPan @k8s-ci-robot @gaoning777 @animeshsingh