Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding myself as reviewer for samples #1174

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Conversation

animeshsingh
Copy link
Contributor

@animeshsingh animeshsingh commented Apr 16, 2019

have been reviewing quite a few, and should be able to handle general review for sample pipleines


This change is Reviewable

have been reviewing quite a few, and should be able to handle general review for sample pipleines
@vicaire
Copy link
Contributor

vicaire commented Apr 16, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@animeshsingh
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@animeshsingh: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-pipeline-e2e-test 3e375e9 link /test kubeflow-pipeline-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vicaire vicaire merged commit d673a1f into kubeflow:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants