WIP feat(frontend,backend): Remove deprecated Python-based Visualizations #11724
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
requested review from
gkcalat,
HumairAK,
jlyaoyuli,
mprahl,
rimolive and
zijianjoy
|
Hi @Zxenith. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Zxenith
force-pushed
the
remove-visualization-server
branch
from
5df7e25 to
5ffbac6
Compare
Zxenith
changed the title
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
|
Hey @Zxenith, are you working on this PR? |
@milinddethe15 yes I am still working on it in my local environment. Sorry about the delay, still debugging :) |
|
@Zxenith @milinddethe15 you can also work on it together :-) Maybe have a zoom call together. In the end it is a revival / rebase of #11134 |
|
@juliusvonkohout absolutely will do that! It would be much easier for us both if we work on the PR together. @milinddethe15 can I contact you via mail? |
Yes, sure |
|
/retest |
1 similar comment
|
/retest |
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
|
/retest |
|
yes you may remove any tests that is testing the code being removed for viz server |
|
and please rebase to master to fix the conflicts. |
|
@Zxenith Let me know your status on this PR |
|
@milinddethe15 Now that i have got to know what to do with the failed test, it'll only take some time to fully fix the issue. This will be resolved soon and I am still working on it. |
|
@Zxenith Did you see the merge conflicts? Do you think you can work in these fixes? |
|
@rimolive ofcourse! Once the main problem of the removal of visualization server is done (which I am currently working on), it won't take long to fix the merge conflicts. |
|
This change can save terabytes of memory on clusters with many (1000) users and therefore large servicemeshes :-) i am using that manually for years. |
Signed-off-by: Akarshan <akarshan.internet@gmail.com>
Signed-off-by: Akarshan <akarshan.internet@gmail.com>
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
… server >> Signed-off-by: Zxenith <akarshan.internet@gmail.com> Signed-off-by: Akarshan <akarshan.internet@gmail.com>
Zxenith
force-pushed
the
remove-visualization-server
branch
from
3a39da1 to
bc35e26
Compare
Signed-off-by: Akarshan <akarshan.internet@gmail.com>
Signed-off-by: Akarshan <akarshan.internet@gmail.com>
|
/retest |
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
|
I think there is still some pages using the to-be-removed |
|
|
Description of your changes:
Removes deprecated Python-based visualizations, including predefined and custom categories, along with the visualization server.
Fixes: #11133
It is a revival of #11134
Checklist: