Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated the component image release script #1172

Merged
merged 1 commit into from
May 3, 2019
Merged

Automated the component image release script #1172

merged 1 commit into from
May 3, 2019

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Apr 16, 2019 •
edited by jlewi
Loading

The script now clones clean repo, makes the changes and commits them.
Then it optionally pushes the changes to a new release branch and even opens the web-browser with a pull request page ready.

This change is Reviewable

@Ark-kun
Automated the component image release script
5e6a7d1 
The script now checks out the clean repo, makes the changes and commits them.
Then it optionally pushes the changes to a new release branch and even opens the web-browser with a pull request page ready.
@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 2, 2019

Gentle ping. @gaoning777 @hongye-sun

How can I help you review this PR? Is there any particular problem?

@hongye-sun
Copy link
Contributor

/lgtm

thanks for the change.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 3, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun Ark-kun merged commit 4060415 into kubeflow:master May 3, 2019
@Ark-kun Ark-kun deleted the Automating-the-release-script branch May 3, 2019 19:23
@Ark-kun Ark-kun mentioned this pull request May 3, 2019
Merged
@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 3, 2019

thanks for the change.

Thanks.
#1283 will make it even better

hamedhsn pushed a commit to hamedhsn/pipelines that referenced this pull request May 5, 2019
@Ark-kun @hamedhsn
Automated the component image release script (kubeflow#1172)
757baf1 
The script now checks out the clean repo, makes the changes and commits them.
Then it optionally pushes the changes to a new release branch and even opens the web-browser with a pull request page ready.
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@yuzisun
Allow unknown fields when unmarshalling istio resources (kubeflow#1172)
9d899e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

@animeshsingh animeshsingh Awaiting requested review from animeshsingh

Assignees

@IronPan IronPan

@gaoning777 gaoning777

@hongye-sun hongye-sun

Labels
approved area/engprod lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ark-kun @hongye-sun @k8s-ci-robot @IronPan @gaoning777