-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component releasing for 0.1.17 #1171
Conversation
/retest |
/test kubeflow-pipeline-e2e-test |
1 similar comment
/test kubeflow-pipeline-e2e-test |
Can you also try replacing the component branch in samples from master to |
/test kubeflow-pipeline-e2e-test |
Which files exactly? you mean which components in the sample directory? |
I meant
and
I should probably extend the |
Note that the SHA you use when loading components is different than the image SHA. (It's actually the SHA of your commit where you change the image tags.) |
Then it requires two commit, then? |
Yes. But they can be submitted in one PR. |
that is not a good a idea to reference a yaml that exists in other forks |
/test kubeflow-pipeline-sample-test |
Here are the recommended steps:
Later when we deprecate the intermediate YAML the regular process will resume. |
SGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want to revert the changes in the sample directory? I think it's fine to change samples too but it will be a overriden in the next PR.
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@IronPan |
release new components and remove the resnet image release in the release script
This change is