Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component releasing for 0.1.17 #1171

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Component releasing for 0.1.17 #1171

merged 1 commit into from
Apr 16, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Apr 15, 2019

release new components and remove the resnet image release in the release script


This change is Reviewable

@gaoning777 gaoning777 changed the title release new components and remove the resnet image release in the rel… Component releasing for 0.1.17 Apr 15, 2019
@gaoning777
Copy link
Contributor Author

/retest

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

1 similar comment
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 15, 2019

Can you also try replacing the component branch in samples from master to 439d90cf194cade07b2a6ede3f7a493b08b537e9 ?

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

Can you also try replacing the component branch in samples from master to 439d90cf194cade07b2a6ede3f7a493b08b537e9 ?

Which files exactly? you mean which components in the sample directory?

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 15, 2019

I meant

dataflow_tf_transform_op = components.load_component_from_url('https://raw.githubusercontent.com/kubeflow/pipelines/master/components/dataflow/tft/component.yaml')

and
confusion_matrix_op = components.load_component_from_url('https://raw.githubusercontent.com/kubeflow/pipelines/master/components/local/confusion_matrix/component.yaml')

I should probably extend the release.sh script to do that automatically.

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 15, 2019

Note that the SHA you use when loading components is different than the image SHA. (It's actually the SHA of your commit where you change the image tags.)

@gaoning777
Copy link
Contributor Author

Then it requires two commit, then?

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 16, 2019

Then it requires two commit, then?

Yes. But they can be submitted in one PR.
I'll be changing the release.sh script to do that automatically in future.

@gaoning777
Copy link
Contributor Author

that is not a good a idea to reference a yaml that exists in other forks

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@IronPan
Copy link
Member

IronPan commented Apr 16, 2019

Here are the recommended steps:

  1. Update the images tag in component folder to latest version that tests pass, using release script and run against component/ dir.
  2. Merge the PR in step 1 and wait for test pass
  3. Update the image tag in sample folders to merge SHA in step 2, using release script and run against sample/ dir.
  4. Merge the PR in step 3.

Later when we deprecate the intermediate YAML the regular process will resume.

@gaoning777
Copy link
Contributor Author

SGTM

Copy link
Member

@IronPan IronPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want to revert the changes in the sample directory? I think it's fine to change samples too but it will be a overriden in the next PR.

@IronPan
Copy link
Member

IronPan commented Apr 16, 2019

/lgtm

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 16, 2019

  1. Update the images tag in component folder to latest version that tests pass, using release script and run against component/ dir.
  2. Merge the PR in step 1 and wait for test pass
  3. Update the image tag in sample folders to merge SHA in step 2, using release script and run against sample/ dir.

@IronPan
There is no problem in updating all images in both components directory and samples directory at the same time. The release script is doing the right thing.
There is no need to split this step in two/three.

@k8s-ci-robot k8s-ci-robot merged commit 785d474 into kubeflow:master Apr 16, 2019
@gaoning777 gaoning777 deleted the release-17 branch April 16, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants