Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Replaced insecure yaml.load with yaml.safe_load #1170

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Apr 15, 2019

This improves security and gets rid of security warnings.
See https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation


This change is Reviewable

@gaoning777
Copy link
Contributor

Please resolve the conflict. Otherwise, lgtm

@Ark-kun Ark-kun force-pushed the SDK---Replaced-insecure-yaml.load-with-yaml.safe_load branch from bde285c to 69e7c1a Compare April 23, 2019 19:33
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 23, 2019

Please resolve the conflict. Otherwise, lgtm

@gaoning777 I've resolved the conflict.

@gaoning777
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 23, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 848d4fb into kubeflow:master Apr 23, 2019
@Ark-kun Ark-kun deleted the SDK---Replaced-insecure-yaml.load-with-yaml.safe_load branch April 25, 2019 06:36
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Move KFServing CI to AWS

* disable gcs test

* delete eks cluster

* Use AWS ECR registory

* Fix builds

* configure kubectl for eks

* install yq

* Use default namespace

* Attach aws key envs

* Upgrade awscli

* Run eks get-token command

* wait for kfserving controller to be ready

* Try hostname on the ingress

* Use PULL_BASE_SHA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants