Adding myself as a reviewer for components #1161
Conversation
Have been reviewing many components and sample related PRs, and feel pretty confident addressing them
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vicaire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vicaire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@animeshsingh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* WIP: Add torchserve to v1beta1 spec - Add torchserve sample - Add Readme document - Update pytorch image in inferenceservice configmap * Feature: Add model archiver for torchserve * Feature: Add Readme for canary and autoscaling * Fix: Removed "strconv" unused pkg * Revert "Feature: Add model archiver for torchserve" This reverts commit d1f7e37d59e3c0023e1b5f655d7da80960aacca8. * Feature: Add mnist example with image transformer for torchserve * Feature: Add support for torchserve along with pytorchserver * Fix: Update deployment yaml files * Feature: Add testcase for torchserve predictor * Revert "Feature: Add testcase for torchserve predictor" This reverts commit d0cc3d15c54630e122e1d21c5ea73d8242437f30. * Fix: Update readme, test inference config, torchserve predictor - fix canary and autoscaling readme - fix test inference configmap - fix torchserve verison check for modelclassname - fix inference service conversion * Fix: Update readme and yaml for torchserve predictor request, response * Fix: Update yaml, readme and predictor images - update predictor images in inference config - update kfserving version in image transformer - fix image transformer docker file - fix deployment yaml with prebuilt marfile - fix readme doc * Fix: Update transformer yaml and ci fix * Feature: Add test case for torchserve predictor - fix protocol validation for model class name
Have been reviewing many components and sample related PRs, and feel pretty confident addressing them
This change is