-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow adding pipeline with name and description. #1139
Conversation
/lgtm |
/test kubeflow-pipeline-e2e-test |
Can you approve as well @gaoning777 ? I don't have permissions to approve. Thanks. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold This seems to be conflicting with the following earlier PR: #1120 The |
/test kubeflow-pipeline-e2e-test |
|
/cancel hold |
Talked offline:
We need to properly hide this private class, but now we might need to do it gradually without breaking backwards compatibility. |
I've fixed the merge conflict. |
Add back the ability to add a pipeline with just the name and description (i.e., not just using the new PipelineMeta construct). This ensures backward compatibility with TFX pipelines SDK.
This fix should obviate the need to pin KFP version as was previously done in tensorflow/tfx#30.
/assign @gaoning777
This change is