Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding pipeline with name and description. #1139

Merged
merged 2 commits into from
Apr 13, 2019

Conversation

neuromage
Copy link
Contributor

@neuromage neuromage commented Apr 11, 2019

Add back the ability to add a pipeline with just the name and description (i.e., not just using the new PipelineMeta construct). This ensures backward compatibility with TFX pipelines SDK.

This fix should obviate the need to pin KFP version as was previously done in tensorflow/tfx#30.

/assign @gaoning777


This change is Reviewable

@gaoning777
Copy link
Contributor

/lgtm

@neuromage
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@neuromage
Copy link
Contributor Author

Can you approve as well @gaoning777 ? I don't have permissions to approve. Thanks.

@gaoning777
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 11, 2019

/hold

This seems to be conflicting with the following earlier PR: #1120
There is not need for a global variable holding all pipeline functions. The attributes can be set on the pipeline function itself.

The dsl.Pipeline is a private compiler context which I'm moving to the dsl-compiler in a next PR. We should not use it to pass pipeline attributes.

@neuromage
Copy link
Contributor Author

neuromage commented Apr 11, 2019

/test kubeflow-pipeline-e2e-test

@neuromage
Copy link
Contributor Author

The dsl.Pipeline is a private compiler context which I'm moving to the dsl-compiler in a next PR. We should not use it to pass pipeline attributes.
This is already a public-facing function, and this is to fix a breakage in the TFX pipeline construction. Please don't break API compatibility. You are free to deprecate APIs, but not remove them.

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 11, 2019

/cancel hold

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 11, 2019

Talked offline:

  • Pipeliene is a private DSL--compiler implementation context class
  • There was a design error made that exposed this class to public
  • Since we did not consider this API to be public, @gaoning777 has modifier some of its methods in a way that broke the backwards compatibility of an undocumented function.
  • TFX integration got broken since it has taken a dependency on this API

We need to properly hide this private class, but now we might need to do it gradually without breaking backwards compatibility.

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 13, 2019

I've fixed the merge conflict.
/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants