Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper to easily add aws secrets #1133

Merged
merged 1 commit into from
Apr 13, 2019

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Apr 10, 2019

Hi Team,

Add aws secrets in kfp.

  1. I notice if I run sdk/python/tests/run_tests.sh, my tests are not detected in the results?
  2. Another thing is should I put this unit test file under tests folder directly? right now it's under tests/dsl

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @Jeffwan. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

Hi @Jeffwan. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan Jeffwan changed the title Allow users to add aws secrets Add helper to easily add aws secrets Apr 10, 2019
AWS_ACCESS_KEY_ID: YOUR_AWS_ACCESS_KEY_ID
AWS_SECRET_ACCESS_KEY: YOUR_AWS_SECRET_ACCESS_KEY

We would suggest users to attach minimum policis or roles to get AWS APIs access.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We would suggest users to attach minimum policis or roles to get AWS APIs access.
We would suggest users to attach minimum policies or roles to get AWS APIs access.

This line is a bit unclear. What exactly do we want from users?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of creating a role with lots of permissions, I think it's better to ask users to attach minimum permission based on their needs.

This line is not helpful in the code, I will remove it.

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 12, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot assigned Ark-kun and unassigned Ark-kun Apr 12, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 12, 2019

Fixes #1131

@Jeffwan
Copy link
Member Author

Jeffwan commented Apr 12, 2019

@Ark-kun could you help look at my questions in the description? I am trying to make sure all tests pass.

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 13, 2019

  • I notice if I run sdk/python/tests/run_tests.sh, my tests are not detected in the results?

The current situation is that we run multiple sets of SDK tests:

# DSL tests

  • run_tests.sh runs all discoverable tests ("test_*.py" files)
  • There are also tests executed by running tests/dsl/main.py and tests/compiler/main.py

To make your test run, you should either rename the test code file or add the test to tests/dsl/main.py .

  • Another thing is should I put this unit test file under tests folder directly? right now it's under tests/dsl

Let's put the test in tests/dsl for now. We might move it later.

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 13, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit af9d48a into kubeflow:master Apr 13, 2019
@Jeffwan Jeffwan deleted the add_aws_secret branch April 13, 2019 01:47
@Jeffwan Jeffwan mentioned this pull request May 5, 2019
5 tasks
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants