Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply latest doc review changes to github docs #1128

Merged
merged 3 commits into from
Apr 18, 2019
Merged

Apply latest doc review changes to github docs #1128

merged 3 commits into from
Apr 18, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Apr 10, 2019 •
edited by jlewi
Loading

This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 10, 2019

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 10, 2019

/test kubeflow-pipeline-e2e-test

@hongye-sun hongye-sun assigned Ark-kun and gaoning777 and unassigned Ark-kun Apr 16, 2019
@hongye-sun
Copy link
Contributor Author

/approve

@hongye-sun
Copy link
Contributor Author

/approve cancel

@hongye-sun
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongye-sun
Copy link
Contributor Author

@Ark-kun and @gaoning777, could you give me the LGTM label to trigger the merge? Thanks.

@gaoning777
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 1115fa5 into kubeflow:master Apr 18, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@pugangxa
Support Kubernetes 1.18 (kubeflow#1128)
d1de88c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees

@Ark-kun Ark-kun

@gaoning777 gaoning777

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hongye-sun @Ark-kun @k8s-ci-robot @gaoning777