Surface workflow finished time in list run API #1122
Conversation
|
/test kubeflow-pipeline-e2e-test |
| "WorkflowSpecManifest": r.WorkflowSpecManifest, | ||
| "Parameters": r.Parameters, | ||
| }).ToSql() | ||
| "UUID": r.UUID, |
There was a problem hiding this comment.
Are all these whitespace changes intentional?
| @@ -135,6 +135,14 @@ func (w *Workflow) ScheduledAtInSecOr0() int64 { | |||
| return 0 | |||
| } | |||
|
|
|||
| func (w *Workflow) FinishedAt() int64 { | |||
| if w.Status.FinishedAt.IsZero(){ | |||
There was a problem hiding this comment.
this doesn't need to be nil-checked?
There was a problem hiding this comment.
no finishedAt is a struct not a pointer so it won't be nil. checking zero should be good.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
- change to use port 9443 - add rbac for finalizer
/assign @rileyjbauer
This change is