Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for API servers #112

Merged
merged 28 commits into from
Nov 10, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions backend/api/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,3 @@ all:
# Instructions to install the 'autogen' command are located here:
# https://github.com/mbrukman/autogen
find ./ -name "*.go" -exec autogen.sh -i --no-tlc -c "Google LLC" -l apache {} \;

# Hack to fix an issue with go-swagger.
# See https://github.com/go-swagger/go-swagger/issues/1170
cp ./text_marshmaller_hack.txt ./go_http_client/pipeline_upload_model/text_marshmaller_hack.go
11 changes: 11 additions & 0 deletions backend/api/experiment.proto
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ syntax = "proto3";
package api;

import "google/api/annotations.proto";
import "google/protobuf/empty.proto";
import "google/protobuf/timestamp.proto";
import "protoc-gen-swagger/options/annotations.proto";

Expand Down Expand Up @@ -73,6 +74,12 @@ service ExperimentService {
get: "/apis/v1beta1/experiments"
};
}

rpc DeleteExperiment(DeleteExperimentRequest) returns (google.protobuf.Empty) {
option (google.api.http) = {
delete: "/apis/v1beta1/experiments/{id}"
};
}
}

message CreateExperimentRequest {
Expand All @@ -96,6 +103,10 @@ message ListExperimentsResponse {
string next_page_token = 2;
}

message DeleteExperimentRequest{
string id = 1;
}

message Experiment {
// Output. Unique experiment ID. Generated by API server.
string id = 1;
Expand Down
147 changes: 112 additions & 35 deletions backend/api/go_client/experiment.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

60 changes: 60 additions & 0 deletions backend/api/go_client/experiment.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading