Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the package version in the notebooks #1117

Merged

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Apr 9, 2019

This change is Reviewable

@gaoning777
Copy link
Contributor

@Ark-kun Ark-kun force-pushed the Updated-package-version-in-notebooks branch from b214618 to 953cc5f Compare April 9, 2019 18:55
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 9, 2019

would you mind also updating the version : https://github.com/kubeflow/pipelines/blob/master/samples/notebooks/DSL%20Static%20Type%20Checking.ipynb

Done. Missed that one as it used kfp-experimental.tar.gz

@gaoning777
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 11, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit eb58f50 into kubeflow:master Apr 12, 2019
@@ -18,7 +18,7 @@
"outputs": [],
"source": [
"!pip3 install https://storage.googleapis.com/ml-pipeline/tfx/tfx-0.12.0rc0-py2.py3-none-any.whl \n",
"!pip3 install https://storage.googleapis.com/ml-pipeline/release/0.1.10/kfp.tar.gz --upgrade\n"
"!pip3 install https://storage.googleapis.com/ml-pipeline/release/0.1.16/kfp.tar.gz --upgrade\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kfp-0.1.16 isn't compatible with tfx-0.12.0 due to change in add_pipeline signature

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!
We've fixed the issue in v0.1.17 and will update the samples soon.
We're also fixing TFX: tensorflow/tfx#39

@Ark-kun Ark-kun deleted the Updated-package-version-in-notebooks branch April 22, 2019 21:24
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* add 1.4.1 release patch

* update kubectl-wrapper to latest to avoid image version conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants