Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the "XGBoost Trainer'" sample #1116

Merged
merged 3 commits into from
Apr 19, 2019
Merged

Updated the "XGBoost Trainer'" sample #1116

merged 3 commits into from
Apr 19, 2019

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Apr 9, 2019 •
edited by IronPan
Loading

Modernized the sample pipeline code.
/assign @gaoning777 @hongye-sun
/label area/samples

This change is Reviewable

@Ark-kun
Updated the "XGBoost Trainer'" sample
fe58366 
Modernized the sample pipeline code.
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 9, 2019

The sample tests have passed. https://prow.k8s.io/pr-history/?org=kubeflow&repo=pipelines&pr=1116

@hongye-sun
Copy link
Contributor

/lgtm

@Ark-kun Ark-kun force-pushed the Updated-the-"XGBoost-Trainer'"-sample branch from 7b54ca0 to 86e58ba Compare April 19, 2019 00:36
@k8s-ci-robot k8s-ci-robot removed the lgtm label Apr 19, 2019
@Ark-kun Ark-kun force-pushed the Updated-the-"XGBoost-Trainer'"-sample branch from 86e58ba to 7b54ca0 Compare April 19, 2019 00:43
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 19, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongye-sun
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 19, 2019

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit cf06ded into kubeflow:master Apr 19, 2019
@Ark-kun Ark-kun deleted the Updated-the-"XGBoost-Trainer'"-sample branch April 24, 2019 04:37
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@Tomcli
feat(backend): Update db table config with Primary key to improve db …
1ec34bf 
…read performance (kubeflow#1116)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

Assignees

@gaoning777 gaoning777

@hongye-sun hongye-sun

Labels
approved area/samples lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ark-kun @hongye-sun @k8s-ci-robot @gaoning777