Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced deprecated image repos with registry.k8s.io #11152

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

HumairAK
Copy link
Collaborator

Resolve: #10615 (comment)

I didn't do any manual test, but seems like a safe change. There is effectively no difference between these images:

~ $ podman image diff --format json registry.k8s.io/busybox gcr.io/google-containers/busybox
{}
~$ podman image diff --format json registry.k8s.io/busybox k8s.gcr.io/busybox
{}

This change was applied via a sed replace like manner.

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@HumairAK
Copy link
Collaborator Author

@chensun / @zijianjoy

Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@chensun
Copy link
Member

chensun commented Sep 6, 2024

Might be safer to merge this after the release

@HumairAK
Copy link
Collaborator Author

HumairAK commented Sep 9, 2024

cc @chensun, as we are post release it seems

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit d23b72b into kubeflow:master Sep 12, 2024
14 checks passed
sefgsefg pushed a commit to sefgsefg/pipelines that referenced this pull request Sep 18, 2024
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: sefgsefg <sefgsefg@gmail.com>
sefgsefg pushed a commit to sefgsefg/pipelines that referenced this pull request Sep 18, 2024
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: sefgsefg <sefgsefg@gmail.com>
R3hankhan123 pushed a commit to R3hankhan123/pipelines that referenced this pull request Sep 20, 2024
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
sefgsefg pushed a commit to sefgsefg/pipelines that referenced this pull request Sep 20, 2024
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
zed546213 pushed a commit to zed546213/pipelines that referenced this pull request Sep 23, 2024
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: zed546213 <zed546213@gmail.com>
chris454656 pushed a commit to chris454656/pipelines that referenced this pull request Sep 24, 2024
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: chris <chris20120826@gmail.com>
Henry551 pushed a commit to Henry551/pipelines that referenced this pull request Sep 25, 2024
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: Henry551 <henry55188@gmail.com>
boarder7395 pushed a commit to boarder7395/pipelines that referenced this pull request Oct 17, 2024
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Please stop using gcr.io/google-containers, k8s.gcr.io
4 participants