-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaced deprecated image repos with registry.k8s.io #11152
Conversation
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Might be safer to merge this after the release |
cc @chensun, as we are post release it seems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com> Signed-off-by: sefgsefg <sefgsefg@gmail.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com> Signed-off-by: sefgsefg <sefgsefg@gmail.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com> Signed-off-by: zed546213 <zed546213@gmail.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com> Signed-off-by: chris <chris20120826@gmail.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com> Signed-off-by: Henry551 <henry55188@gmail.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Resolve: #10615 (comment)
I didn't do any manual test, but seems like a safe change. There is effectively no difference between these images:
This change was applied via a sed replace like manner.