Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the "Kubeflow training and classification" sample #1114

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Apr 9, 2019

Modernized the sample pipeline code.
/assign @gaoning777 @hongye-sun
/label area/samples


This change is Reviewable

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 9, 2019

The sample tests have passed. https://prow.k8s.io/pr-history/?org=kubeflow&repo=pipelines&pr=1114

@hongye-sun
Copy link
Contributor

/lgtm

@hongye-sun hongye-sun closed this Apr 19, 2019
@hongye-sun
Copy link
Contributor

accidentally closed the PR. reopen.

@hongye-sun hongye-sun reopened this Apr 19, 2019
@hongye-sun
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Apr 19, 2019
@hongye-sun
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 19, 2019

/test kubeflow-pipeline-sample-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 19, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 00c39da into kubeflow:master Apr 19, 2019
@Ark-kun Ark-kun deleted the Updated-the-"Kubeflow-training-and-classification"-sample branch April 22, 2019 23:17
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants