Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update api-generator to use golang 1.20 #10580

Merged

Conversation

chensun
Copy link
Member

@chensun chensun commented Mar 15, 2024

Description of your changes:
Part of #10579

Checklist:

Signed-off-by: Chen Sun <chensun@users.noreply.github.com>
@chensun chensun force-pushed the update-golang-in-api-generator branch from 677bdef to 0da870c Compare March 15, 2024 22:24
@chensun
Copy link
Member Author

chensun commented Mar 15, 2024

/retest-required

@rimolive
Copy link
Member

/ok-to-test

@rimolive
Copy link
Member

/lgtm

Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@chensun
Copy link
Member Author

chensun commented Mar 18, 2024

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, Tomcli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ba3f663 into kubeflow:master Mar 18, 2024
6 checks passed
@chensun chensun deleted the update-golang-in-api-generator branch March 18, 2024 23:04
@chensun chensun mentioned this pull request Mar 20, 2024
1 task
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 27, 2024
Signed-off-by: Chen Sun <chensun@users.noreply.github.com>
gmfrasca added a commit to gmfrasca/data-science-pipelines that referenced this pull request Mar 27, 2024
gmfrasca added a commit to gmfrasca/data-science-pipelines that referenced this pull request Mar 27, 2024
gmfrasca added a commit to gmfrasca/data-science-pipelines that referenced this pull request Mar 27, 2024
…ubeflow#10580)"

This reverts commit ba3f663.

Signed-off-by: Giulio Frasca <gfrasca@redhat.com>
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
Signed-off-by: Chen Sun <chensun@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants