Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Backend + SDK): Add missing optional field to SecretAsVolume and … #10550

Merged
merged 7 commits into from
Apr 3, 2024

Conversation

revit13
Copy link
Contributor

@revit13 revit13 commented Mar 10, 2024

…ConfigMapAsVolume. Fixes #10548.

Description of your changes:
Part of #9714, #10400, #10483 and #10549

This PR supports the addition of missing optional fields to SecretAsVolume and ConfigMapAsVolume introduced in #10549. The fields were added to avoid failure when the secret or config map used as volume source are missing.

To be rebased and update go.mod after #10548.

Checklist:

Copy link

Hi @revit13. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…ConfigMapAsVolume.

Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
@Tomcli
Copy link
Member

Tomcli commented Mar 13, 2024

/ok-to-test

Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @chensun

Signed-off-by: Revital Sur <eres@il.ibm.com>
@google-oss-prow google-oss-prow bot removed the lgtm label Mar 24, 2024
@rimolive
Copy link
Member

/lgtm

Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@chensun could you review this PR? Thanks.

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Tomcli
Copy link
Member

Tomcli commented Mar 25, 2024

/test kubeflow-pipeline-backend-test

@Tomcli
Copy link
Member

Tomcli commented Mar 26, 2024

/retest

Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
@google-oss-prow google-oss-prow bot removed the lgtm label Mar 27, 2024
Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Mar 27, 2024
@Tomcli
Copy link
Member

Tomcli commented Mar 27, 2024

Opened issue #10629 to track failing tests. Once upstream fixed the tests, we might need to rebase again.

@rimolive
Copy link
Member

rimolive commented Apr 3, 2024

@revit13 Please rebase your PR to get the latest client code changes.

Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
@google-oss-prow google-oss-prow bot removed the lgtm label Apr 3, 2024
Copy link

google-oss-prow bot commented Apr 3, 2024

@revit13: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 9c61a86 link false /test kubeflow-pipelines-samples-v2
kfp-kubernetes-execution-tests 9c61a86 link false /test kfp-kubernetes-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Apr 3, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, Tomcli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a78dc77 into kubeflow:master Apr 3, 2024
12 of 14 checks passed
rimolive pushed a commit to rimolive/data-science-pipelines that referenced this pull request Apr 9, 2024
kubeflow#10550)

* fix(Backend + SDK): Add missing optional field to SecretAsVolume and ConfigMapAsVolume.

Signed-off-by: Revital Sur <eres@il.ibm.com>

* Update after rebase.

Signed-off-by: Revital Sur <eres@il.ibm.com>

* Update after rebase.

Signed-off-by: Revital Sur <eres@il.ibm.com>

* Update after merge.

Signed-off-by: Revital Sur <eres@il.ibm.com>

* Updates after merge with master branch.

Signed-off-by: Revital Sur <eres@il.ibm.com>

---------

Signed-off-by: Revital Sur <eres@il.ibm.com>
openshift-merge-bot bot added a commit to opendatahub-io/data-science-pipelines that referenced this pull request Apr 16, 2024
VaniHaripriya pushed a commit to VaniHaripriya/data-science-pipelines that referenced this pull request Sep 23, 2024
kubeflow#10550)

* fix(Backend + SDK): Add missing optional field to SecretAsVolume and ConfigMapAsVolume.

Signed-off-by: Revital Sur <eres@il.ibm.com>

* Update after rebase.

Signed-off-by: Revital Sur <eres@il.ibm.com>

* Update after rebase.

Signed-off-by: Revital Sur <eres@il.ibm.com>

* Update after merge.

Signed-off-by: Revital Sur <eres@il.ibm.com>

* Updates after merge with master branch.

Signed-off-by: Revital Sur <eres@il.ibm.com>

---------

Signed-off-by: Revital Sur <eres@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sdk] Missing optional parameter to v2 use_config_map_as_volume and use_secret_as_volume
4 participants