Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the metadata property to ComponentSpec #1023

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Mar 22, 2019

The metadata section contains the annotations and labels dictionaries.
Fixes #1013


This change is Reviewable

The `metadata` section contains the `annotations` and `labels` dictionaries.
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Mar 22, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@animeshsingh animeshsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@animeshsingh
Copy link
Contributor

animeshsingh commented Mar 23, 2019

Thanks @Ark-kun - will help wrt #1023

@k8s-ci-robot k8s-ci-robot merged commit 9b80468 into kubeflow:master Mar 23, 2019
@Ark-kun Ark-kun deleted the Added-the-metadata-property-to-ComponentSpec branch March 27, 2019 20:26
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants